Skip to content

Conversation

TaoZou1
Copy link
Contributor

@TaoZou1 TaoZou1 commented Jul 31, 2025

Remove redundant code.
Use switch to replace some if clause.
Cast type in switch instead of in case clause

Remove redundant code.
Use switch to replace some if clause.
Cast type in switch instead of case
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 70.37037% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.83%. Comparing base (051011c) to head (afb25e3).

Files with missing lines Patch % Lines
cmd/main.go 0.00% 8 Missing ⚠️
pkg/nsx/services/common/store.go 0.00% 1 Missing and 1 partial ⚠️
pkg/nsx/services/securitypolicy/firewall.go 75.00% 2 Missing ⚠️
pkg/nsx/util/utils.go 33.33% 1 Missing and 1 partial ⚠️
pkg/nsx/services/inventory/builder.go 66.66% 1 Missing ⚠️
pkg/nsx/services/vpc/vpc.go 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1186      +/-   ##
==========================================
+ Coverage   73.81%   73.83%   +0.02%     
==========================================
  Files         141      141              
  Lines       22350    22342       -8     
==========================================
- Hits        16498    16497       -1     
+ Misses       4829     4824       -5     
+ Partials     1023     1021       -2     
Flag Coverage Δ
unit-tests 73.83% <70.37%> (+0.02%) ⬆️
Files with missing lines Coverage Δ
pkg/clean/clean.go 85.83% <100.00%> (ø)
pkg/clean/clean_service.go 64.76% <100.00%> (-0.17%) ⬇️
pkg/controllers/networkinfo/networkinfo_utils.go 78.99% <ø> (-0.09%) ⬇️
pkg/controllers/subnet/subnet_controller.go 70.04% <100.00%> (ø)
pkg/controllers/subnetset/subnetset_controller.go 75.12% <100.00%> (ø)
pkg/nsx/cluster.go 62.60% <ø> (ø)
pkg/nsx/services/common/policy_tree.go 77.17% <100.00%> (ø)
pkg/nsx/services/securitypolicy/builder.go 85.82% <100.00%> (+<0.01%) ⬆️
pkg/nsx/services/securitypolicy/expand.go 68.29% <100.00%> (+0.11%) ⬆️
pkg/nsx/services/securitypolicy/parse.go 96.42% <100.00%> (ø)
... and 8 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhengxiexie
Copy link
Contributor

/e2e

4 similar comments
@zhengxiexie
Copy link
Contributor

/e2e

@zhengxiexie
Copy link
Contributor

/e2e

@zhengxiexie
Copy link
Contributor

/e2e

@TaoZou1
Copy link
Contributor Author

TaoZou1 commented Aug 25, 2025

/e2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants