-
Notifications
You must be signed in to change notification settings - Fork 21
Add sophisticated log track when cleaning resources by wcp #1268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zhengxiexie
wants to merge
1
commit into
vmware-tanzu:main
Choose a base branch
from
zhengxiexie:topic/zhengxie/main/clean_more
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add sophisticated log track when cleaning resources by wcp #1268
zhengxiexie
wants to merge
1
commit into
vmware-tanzu:main
from
zhengxiexie:topic/zhengxie/main/clean_more
+328
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1268 +/- ##
==========================================
+ Coverage 74.42% 74.52% +0.09%
==========================================
Files 147 147
Lines 23637 23894 +257
==========================================
+ Hits 17593 17808 +215
- Misses 4952 4980 +28
- Partials 1092 1106 +14
🚀 New features to boost your workflow:
|
yanjunz97
reviewed
Oct 20, 2025
e93aec0
to
908af6f
Compare
yanjunz97
reviewed
Oct 21, 2025
95f754e
to
bca7a21
Compare
yanjunz97
previously approved these changes
Oct 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TaoZou1
reviewed
Oct 21, 2025
bca7a21
to
4e1da05
Compare
It's a bit hard to debug clean failure when triggered by wcp, so added as many logs as possible to make debugging easier in the future. Change-Id: Ia958b9b6cd50ac617369e9605cd99bac0dcb2305
4e1da05
to
dd84629
Compare
TaoZou1
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a bit hard to debug clean failure when triggered by wcp, so added as many logs as possible to make debugging easier in the future.
Test done
Change-Id: Ia958b9b6cd50ac617369e9605cd99bac0dcb2305