change

vmware-tanzu · May 1, 2024 · d80e419 · d80e419
1 parent 0876913
commit d80e419
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkg/command/plugin.go b/pkg/command/plugin.go
@@ -257,7 +257,6 @@ func newInstallPluginCmd() *cobra.Command {
 					return err
 				}
 				err = pluginmanager.InstallPluginsFromLocalSource(pluginName, version, getTarget(), local, false)
-				pluginmanager.StopSpinner()
 				if err != nil {
 					return err
 				}
@@ -280,7 +279,6 @@ func newInstallPluginCmd() *cobra.Command {
 
 			pluginVersion := version
 			err = pluginmanager.InstallStandalonePlugin(pluginName, pluginVersion, getTarget())
-			pluginmanager.StopSpinner()
 			if err != nil {
 				return err
 			}
@@ -343,6 +341,7 @@ func newUpgradePluginCmd() *cobra.Command {
 
 			// With the Central Repository feature we can simply request to install
 			// the recommendedVersion.
+			pluginmanager.SetTotalPluginsToInstall(1)
 			err = pluginmanager.UpgradePlugin(pluginName, cli.VersionLatest, getTarget())
 			if err != nil {
 				return err

diff --git a/pkg/pluginmanager/manager.go b/pkg/pluginmanager/manager.go
@@ -1182,6 +1182,7 @@ func InstallPluginsFromLocalSource(pluginName, version string, target configtype
 		return errors.Errorf("unable to find plugin '%v' matching version '%v'", pluginName, version)
 	}
 
+	defer StopSpinner()
 	if len(matchedPlugins) == 1 {
 		return installOrUpgradePlugin(&matchedPlugins[0], version, installTestPlugin)
 	}