Skip to content

Conversation

marckhouzam
Copy link
Contributor

What this PR does / why we need it

My IDE showed me that there are a couple of places where we used the wrong dash character instead of the ascii one.
This PR simply replaces them.

For example, when copying the docs where this wrong character was used:

$ tanzu plugin install all -–group vmware-tanzucli/essentials
[x] : unknown shorthand flag: 'â' in -–group

Which issue(s) this PR fixes

Fixes # N/A

Describe testing done for PR

Let CI run

Release note

Convert some characters to their corresponding ascii version.

Additional information

Special notes for your reviewer

@marckhouzam marckhouzam requested a review from a team as a code owner February 28, 2025 17:15
Copy link
Contributor

@prkalle prkalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for fixing this.

(This is very hard to differentiate visually and I encountered simialr issue in the past while testing)

Copy link
Contributor

@anujc25 anujc25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@marckhouzam marckhouzam merged commit 394fd98 into vmware-tanzu:main Mar 1, 2025
8 checks passed
@marckhouzam marckhouzam deleted the marck/cleanup branch March 1, 2025 01:06
@marckhouzam marckhouzam added this to the v1.5.4 milestone Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants