Allowing Object-Level Resource Status Restore #8464
+146
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham-pampattiwar
force-pushed
the
obj-status-restore-impl
branch
from
13c21a6 to
aaf8403
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8464 +/- ##
==========================================
+ Coverage 58.98% 59.40% +0.42%
==========================================
Files 368 370 +2
Lines 39000 40016 +1016
==========================================
+ Hits 23004 23772 +768
- Misses 14532 14751 +219
- Partials 1464 1493 +29 ☔ View full report in Codecov by Sentry. |
shubham-pampattiwar
force-pushed
the
obj-status-restore-impl
branch
from
aaf8403 to
bd2e3e2
Compare
Signed-off-by: Shubham Pampattiwar <[email protected]> add changelog Signed-off-by: Shubham Pampattiwar <[email protected]> Update impl according to design Signed-off-by: Shubham Pampattiwar <[email protected]> make update Signed-off-by: Shubham Pampattiwar <[email protected]>
shubham-pampattiwar
force-pushed
the
obj-status-restore-impl
branch
from
bd2e3e2 to
ca9568e
Compare
sseago
approved these changes
Feb 12, 2025
kaovilai
reviewed
Feb 12, 2025
Comment on lines
+2544
to
+2545
| if annotations == nil { | ||
| log.Warnf("No restore status specific annotation found for %s, using restore spec setting: %v", kube.NamespaceAndName(obj), shouldRestoreStatus) |
There was a problem hiding this comment.
The log is misleading.
This logs when annotation of object is nil, not just because restore status specific annotation is not found.
The same log should be used if annotationExists == false below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Design: #8403
Does your change fix a particular issue?
Fixes #8204
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.