Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing non-CSI PVC restore without existing volume handle #8493 #8675

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mayankagg9722
Copy link
Contributor

@mayankagg9722 mayankagg9722 commented Feb 10, 2025

Fix: #8493

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(8493)

Please indicate you've done the following:

@mayankagg9722 mayankagg9722 changed the title Fixing non CSI restore without existing volume handle #8493 Fixing non-CSI restore without existing volume handle #8493 Feb 10, 2025
@mayankagg9722 mayankagg9722 changed the title Fixing non-CSI restore without existing volume handle #8493 Fixing non-CSI PVC restore without existing volume handle #8493 Feb 10, 2025
@mayankagg9722 mayankagg9722 marked this pull request as ready for review February 10, 2025 17:11
@anshulahuja98 anshulahuja98 added this to the v1.16 milestone Feb 11, 2025
@kaovilai
Copy link
Member

also DCO

mmorel-35 and others added 3 commits February 13, 2025 09:02
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: mayaggar <[email protected]>
Signed-off-by: mayaggar <[email protected]>
Signed-off-by: mayaggar <[email protected]>
@mayankagg9722
Copy link
Contributor Author

also DCO

Fixed this.

Signed-off-by: mayaggar <[email protected]>
@kaovilai
Copy link
Member

Changelog check

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.40%. Comparing base (c8e6238) to head (a116b12).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8675   +/-   ##
=======================================
  Coverage   59.39%   59.40%           
=======================================
  Files         370      370           
  Lines       39998    40000    +2     
=======================================
+ Hits        23758    23760    +2     
  Misses      14747    14747           
  Partials     1493     1493           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: mayaggar <[email protected]>
@mayankagg9722
Copy link
Contributor Author

Changelog check

Thanks @kaovilai for mentioning. I have checked this in and all check gates passed now. Will keep note of these check gates in future PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants