fixing datasource schema for tanzu kubernetes clusters and adding generic helper #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
Signed-off-by: warroyo <[email protected]>
tenthirtyam
force-pushed
the
datasource-helpers
branch
from
887f706 to
0ef77df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where the data source for tanzu kubernetes clusters had fields that were not being marked as computed and could not be used in other parts of the terraform code.
This adds a helper that modifies the schema to be specific to datasources . This helper can be re-used for other datasources. The helper is also implemented in the tanzu_kubernetes_cluster datasources
Type
Please describe:
Breaking Changes?
Test and Documentation
no documentation needed since there is no change to the user experience. Tested creating a cluster and getting the data back using the datatsource and ensuring that it could be referenced before the cluster exists
Issue References
Additional Information