Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gui): invalid chunk/pad range, fix slider minimum #616

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(gui): invalid chunk/pad range, fix slider minimum #616

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c7a905
fix(gui): invalid chunk/pad range, fix slider minimum
brandostrong May 11, 2023
a38c10c
Merge remote-tracking branch 'upstream/main'
brandostrong May 15, 2023
774b0f6
Fix default slider ranges avoiding dividebyzero and zero errors / Def…
brandostrong May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/so_vits_svc_fork/gui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ def main():
sg.Text("Pad seconds"),
sg.Push(),
sg.Slider(
range=(0.0, 1.0),
range=(0.01, 1.0),
orientation="h",
key="pad_seconds",
resolution=0.01,
Expand All @@ -318,7 +318,7 @@ def main():
sg.Text("Chunk seconds"),
sg.Push(),
sg.Slider(
range=(0.0, 3.0),
range=(0.01, 3.0),
orientation="h",
key="chunk_seconds",
resolution=0.01,
Expand Down Expand Up @@ -389,7 +389,7 @@ def main():
),
sg.Push(),
sg.Slider(
range=(0, 3.0),
range=(0.05, 3.0),
orientation="h",
key="block_seconds",
resolution=0.001,
Expand All @@ -402,7 +402,7 @@ def main():
),
sg.Push(),
sg.Slider(
range=(0, 2.0),
range=(0.05, 2.0),
orientation="h",
key="additional_infer_before_seconds",
resolution=0.001,
Expand All @@ -415,7 +415,7 @@ def main():
),
sg.Push(),
sg.Slider(
range=(0, 2.0),
range=(0.05, 2.0),
orientation="h",
key="additional_infer_after_seconds",
resolution=0.001,
Expand Down Expand Up @@ -671,11 +671,11 @@ def apply_preset(name: str) -> None:
# Set a sensible default output path
window.Element("output_path").Update(str(get_output_path(input_path)))
elif event == "infer":
if "Default VC" in values["presets"]:
window["presets"].update(
set_to_index=list(load_presets().keys()).index("Default File")
)
apply_preset("Default File")
# if "Default VC" in values["presets"]:
# window["presets"].update(
# set_to_index=list(load_presets().keys()).index("Default File")
# )
# apply_preset("Default File")
if values["input_path"] == "":
LOG.warning("Input path is empty.")
continue
Expand Down