Open
Conversation
f9364aa to
2aa6bdb
Compare
jtpio
reviewed
Feb 14, 2020
Member
Author
|
There might be a temporary conda issue on OSX, but other than that this is ready to be reviewed @jtpio. |
Member
|
This looks pretty good. I am happy to get this in if you think this is ready @davidbrochart. I think we can probably set up ASV after this. |
Member
Author
|
Should it be only in ASV? The thing is that we don't know which machine we get in the CI, so if the machine is very slow the test can fail, or we should somehow take into account the machine's CPU frequency in the test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test launches 10 clients, all executing the same notebook. The notebook consists of 100 cells, each cell sleeps for 0.1 second. We check:
TimeoutErrorif exceeded).exitcode1 if exceeded).