Clean up and document createLanguageServicePlugin and createAsyncLanguageServicePlugin
#261
+270
−218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machty
commented
Feb 10, 2025
| .map(plugin => plugin.typescript?.extraFileExtensions.map(ext => '.' + ext.extension) ?? []) | ||
| .flat(); | ||
|
|
||
| // TODO: this logic does not seem to appear in the async variant | ||
| // (createAsyncLanguageServicePlugin)... bug? |
There was a problem hiding this comment.
OPEN QUESTION: is it a bug that the async variant (createAsyncLanguageServicePlugin) does not add the extensions passed in to projectExternalFileExtensions? (This is also how it was prior to this PR).
machty
commented
Feb 10, 2025
| if (updateLevel >= (1 satisfies ts.ProgramUpdateLevel.RootNamesAndUpdate) | ||
| || !externalFiles.has(project)) { | ||
| const oldFiles = externalFiles.get(project); | ||
| const extensions = projectExternalFileExtensions.get(project); |
There was a problem hiding this comment.
This is where we check projectExternalFileExtensions (see other comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.