Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTTPS mixed content issue #1888

Merged
merged 24 commits into from
Feb 12, 2016
Merged

Fix HTTPS mixed content issue #1888

merged 24 commits into from
Feb 12, 2016

Conversation

HLFH
Copy link
Contributor

@HLFH HLFH commented Jan 27, 2016

Hi,

@hikalkan

As you can see, it fixes HTTPS mixed content issue.

Thanks to merge.

Sincerely,
HLFH

@hikalkan
Copy link
Member

Thank you very much. Does that cause a problem for HTTP?
There was a related PR here: #1765 it uses //: instead of https://

@HLFH
Copy link
Contributor Author

HLFH commented Jan 28, 2016

@hikalkan No, it does not cause any problem with HTTP. It's better to enforce HTTPS for the fonts, even if you still use HTTP for the main website. Soon, HTTP will be marked as non-secure. It's better to begin the switch. IMHO #1888 is a better fix than #1765.

@HLFH
Copy link
Contributor Author

HLFH commented Feb 3, 2016

@hikalkan Hi. Any news?

hikalkan added a commit that referenced this pull request Feb 12, 2016
Fix HTTPS mixed content issue
@hikalkan hikalkan merged commit d5cbeb5 into volosoft:master Feb 12, 2016
@hikalkan
Copy link
Member

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants