Fix missing action when installing with --strip-dot-git #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
For legacy projects, we want to use the
--strip-dot-gitoption when running thelibrarian-puppet installcommand. This option is listed in the output oflibrarian-puppet help install.We intend to use this option to remove the
.gitdirectory from cloned modules so that we can commit them without having to manage Git submodules.Since this option is documented in the help, I took the liberty of creating a pull request to implement this behavior when the option is enabled.
To get the tests working, I had to pin the version of
minitestto< 5.19.0because the newer version introduced a naming change that causes issues withmocha.Would it be possible to release a new version with this fix?