Add support for Debian #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
control_cmd was not used, now it is add control_setup_cmd as Puppet now requires it to be an absolute path (I put in commands without paths for FreeBSD/OpenBSD that will need to be updated)
smortex
requested changes
Aug 17, 2022
| nsd::service_name: 'nsd' | ||
| nsd::owner: 'nsd' | ||
| nsd::group: 'nsd' | ||
| nsd::control_cmd: '/usr/bin/echo /usr/sbin/nsd-control' |
There was a problem hiding this comment.
Suggested change
| nsd::control_cmd: '/usr/bin/echo /usr/sbin/nsd-control' | |
| nsd::control_cmd: '/usr/sbin/nsd-control' |
| @@ -8,6 +8,7 @@ | |||
| String $service_name, | |||
| Variant[String,Undef] $package_name, | |||
| String $control_cmd, | |||
| String $control_setup_cmd, | |||
There was a problem hiding this comment.
If an empty string is not valid (I guess it is not), better use:
Suggested change
| String $control_setup_cmd, | |
| String[1] $control_setup_cmd, |
We can also use the type form stdlib if the full path is required:
Suggested change
| String $control_setup_cmd, | |
| Stdlib::Absolutepath $control_setup_cmd, |
smortex
changed the title
|
Oh, and if it works on Debian, we can add it to |
Co-authored-by: Romain Tartière <[email protected]>
Co-authored-by: Romain Tartière <[email protected]>
|
@davidc any plans to revisit this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues