Add manage_package parameter and functionality #254
+36
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@trenta thanks for the PR. can you take a look at the failing CI jobs? |
Author
|
So my puppet lint suggests different indents to yours. Should have something configured differently? |
Member
|
@trenta we are usually up2date with the puppet-lint plugins. If you use puppet-lint: that uses older plugins. |
bastelfreak
reviewed
Oct 23, 2025
| Boolean $manage_service = $telegraf::params::manage_service, | ||
| Boolean $manage_repo = $telegraf::params::manage_repo, | ||
| Boolean $manage_archive = $telegraf::params::manage_archive, | ||
| Boolean $manage_package = $telegraf::params::manage_package, |
Member
There was a problem hiding this comment.
$manage_package is always true. In that case you can directly assign the value in the init.pp, and we don't need another variable in the params.pp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This allows users to manage the package themselves if desired.
This Pull Request (PR) fixes the following issues
Fixes #253