Drop SixLabors.ImageSharp; use SkiaSharp in UI tests#14
Merged
Conversation
ImageSharp 4.x went commercial-license-only, blocking PR #10's Appium.WebDriver bump. The picker library already depends on SkiaSharp, so the UI tests can reuse it for the (load PNG / sample pixels / crop / save PNG) surface they actually need. - New ColorPicker.UITests/Infrastructure/PixelImage.cs: thin SKBitmap wrapper exposing Width/Height, this[x,y], Load(bytes|path), Save(path), Crop(x,y,w,h). Pixel(R,G,B,A) record keeps R/G/B/A field names so call sites are unchanged. - Csproj: SixLabors.ImageSharp 3.1.5 -> SkiaSharp 2.88.8 (matches the library's pinned version). - All 11 consumer files in Infrastructure/, PageObjects/ and Tests/ migrated. Pure type/method renames, no behaviour change. - dependabot.yml: drop SixLabors.ImageSharp from the test-stack group. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem.
SixLabors.ImageSharp 4.xswitched to a commercial-only license, so PR #10 (Appium.WebDriver + 4 other test-stack bumps from Dependabot) fails its build witherror : No Six Labors license found.ImageSharpwas introduced only in the MAUI port (the original Xamarin lib never used it, and the picker library itself doesn't depend on it) — purely as a screenshot read/sample helper for the UI tests.Fix. ReplaceImageSharpwithSkiaSharp, which the picker library already ships, so no new transitive dependency.A thinColorPicker.UITests/Infrastructure/PixelImage.cswrapsSKBitmapand exposes exactly the surface the tests use:-Width,Height- indexerthis[int x, int y] -> Pixel-Load(byte[])/Load(string path)-Save(string path)(PNG)-Crop(x, y, w, h)ThePixelrecord deliberately keepsR/G/B/A(notRed/Green/Blue/Alpha) so every existing pixel-sampling test reads identically.Also dropsSixLabors.ImageSharpfrom the dependabottest-stackgroup.Validation.dotnet build ColorPicker.UITests -c Releaseis clean (0 errors). Full CI / UI Tests / Consumer Smoke will exercise the rest.