Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added/auttoken rewriter permission #73

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

iago1501
Copy link
Contributor

@iago1501 iago1501 commented Feb 6, 2025

This PR blocks requests to the redirect mutations when the user doesn't have the role to edit the CMS settings. This is a security fix due to a report made by a client. This event is only called by catalog-graphql, with that, only users allowed to create changes will be able to properly perform it

Role required.

Workspace to test

Hot to test it:
Create a user in the store with those permissions:

image

Try to change link id from a category, brand or product at admin/catalog-translation

If you want to test it into your account, there's a beta version for the store-indexer:

image

Its related to this rewriter fix released

@iago1501 iago1501 added the bug Something isn't working label Feb 6, 2025
@iago1501 iago1501 self-assigned this Feb 6, 2025
Copy link

vtex-io-ci-cd bot commented Feb 6, 2025

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant