feat: add rating field #2636
feat: add rating field #2636
Conversation
artursantiago
added
enhancement
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
artursantiago
requested review from
renatamottam and
renatomaurovtex
and removed request for
a team
artursantiago
force-pushed
the
feat/add-rating-field
branch
from
87776b2 to
fee26d8
Compare
|
I just fixed the preview link. You can test it now. |
| @@ -22,6 +22,7 @@ | |||
| // -------------------------------------------------------- | |||
| // Structural Styles | |||
| // -------------------------------------------------------- | |||
|
|
|||
There was a problem hiding this comment.
todo: fix the button size, it's currently 48px, and should be 32px.
I will suggest adding a new token:
// Button
--fs-rating-button-min-height: var(--fs-spacing-5);
and then on line 34, force the size:
[data-fs-rating-button] {
--fs-button-small-min-height: var(--fs-rating-button-min-height);
There was a problem hiding this comment.
Alright, I've implemented the suggested change, I had previously kept the token value because I thought it was something set for accessibility, so as not to make the touch area so small
| flex-direction: column; | ||
|
|
||
| [data-fs-rating-field-label] { | ||
| font-size: var(--fs-rating-field-label-size); |
There was a problem hiding this comment.
| font-size: var(--fs-rating-field-label-size); | |
| margin-bottom: var(--fs-spacing-0); | |
| font-size: var(--fs-rating-field-label-size); |
| } | ||
|
|
||
| [data-fs-rating-field-error-message] { | ||
| font-size: var(--fs-rating-field-error-message-size); |
There was a problem hiding this comment.
| font-size: var(--fs-rating-field-error-message-size); | |
| margin-top: var(--fs-spacing-0); | |
| font-size: var(--fs-rating-field-error-message-size); |
| // -------------------------------------------------------- | ||
| // Design Tokens for Rating Field | ||
| // -------------------------------------------------------- | ||
|
|
There was a problem hiding this comment.
After fixing the button size as I mention, we need to adds a little margin in the label and error message. I've left as suggestions.
todo: Can you please update this file indentation just to follow the previous pattern? Thank you!
What's the purpose of this pull request?
This pull request adds the RatingField component, which will initially be used in the modal for adding reviews to a product.
How it works?
This PR creates a new molecule component called
RatingField. In addition to the "input" fields for the actionable rating, it can also receive anid,label, anderrorvia props to be displayed in the form. The component uses theRatingcomponent with theactionableview, passing theonChangehandler to it.How to test it?
Starters Deploy Preview
Preview
References
JIRA TASK: SFS-2078
JIRA TASK: SFS-2077
Figma