feat: add checkbox field error variant #2638
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
artursantiago
requested review from
emersonlaurentino and
lariciamota
and removed request for
a team
artursantiago
force-pushed
the
feat/add-checkbox-field-error-variant
branch
from
ca9bc19 to
622ef30
Compare
hellofanny
approved these changes
Feb 4, 2025
|
Is there any "rule" to follow for the identation of the properties? Or just need to space out to be easy to read? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This pull request adds styles and an error text for the CheckboxField component. Additionally, it adjusts the styles of the CheckboxField label. This new styling will be used in the modal for adding a review to a product in the new Reviews and Ratings section.
How it works?
I added the
errorandalignmentprops to theCheckboxFieldcomponent. Thealignmentprop is used to vertically align the checkbox, with the default value set tocenter.Additionally, the
labelwas not previously styled, so I added styles to it based on the Figma to ensure the label is displayed correctly.How to test it?
Starters Deploy Preview
Preview
References
JIRA TASK: SFS-2073
Figma