-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reviews query resolver #2649
Open
Guilera
wants to merge
2
commits into
feat/reviews-and-ratings
Choose a base branch
from
feat/reviews-query-resolver
base: feat/reviews-and-ratings
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+211
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
9d85730
to
439d455
Compare
439d455
to
84d2f9f
Compare
84d2f9f
to
b37404e
Compare
pedromtec
reviewed
Feb 5, 2025
pedromtec
reviewed
Feb 5, 2025
b37404e
to
6dcb384
Compare
6dcb384
to
520af25
Compare
pedromtec
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
To add reviews query resolver on graphQL
How it works?
It defines a few new types and adds a new query resolver called:
reviews
wich retrieves an array of reviews for a specific product.For input we have:
required
)optional
)optional
)optional
)(for filtering)How to test it?
run the api graphql server locally with the following command:
and make a query call
References
JIRA TASK: SFS-2094
Checklist
You may erase this after checking them all 😉
PR Description
Reviews
typesReviews