feat: Multiple global content types #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
eduardoformiga
changed the title
eduardoformiga
requested review from
renatamottam and
lucasfp13
and removed request for
a team
jardelymaris
approved these changes
Feb 4, 2025
lariciamota
reviewed
Feb 26, 2025
Co-authored-by: Larícia Mota <[email protected]>
yeah, the docs @mariana-caetano already started to create. |
lariciamota
approved these changes
Feb 26, 2025
eduardoformiga
deleted the
feat/multiple-global-content-types-SFS-2120
branch
5 tasks
eduardoformiga
added a commit
that referenced
this pull request
Feb 26, 2025
## What's the purpose of this pull request? - #2668 introduces a bug in its last commit. This PR removes the checking for the MissingContentError in getPage ## How it works? <!--- Tell us the role of the new feature, or component, in its context. Provide details about what you have implemented and screenshots if applicable. ---> ## How to test it? <!--- Describe the steps with bullet points. Is there any external link that can be used to better test it or an example? ---> ### Starters Deploy Preview <!--- Add a link to a deploy preview from `starter.store` with this branch being used. ---> <!--- Tip: You can get an installable version of this branch from the CodeSandbox generated when this PR is created. ---> ## References <!--- Spread the knowledge: is there any content you used to create this PR that is worth sharing? ---> <!--- Extra tip: adding references to related issues or mentioning people important to this PR may be good for the documentation and reviewing process ---> ## Checklist <em>You may erase this after checking them all 😉</em> **PR Title and Commit Messages** - [ ] PR title and commit messages follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) specification - Available prefixes: `feat`, `fix`, `chore`, `docs`, `style`, `refactor`, `ci` and `test` **PR Description** - [ ] Added a label according to the PR goal - `breaking change`, `bug`, `contributing`, `performance`, `documentation`.. **Dependencies** - [ ] Committed the `pnpm-lock.yaml` file when there were changes to the packages **Documentation** - [ ] PR description - [ ] For documentation changes, ping `@Mariana-Caetano` to review and update (Or submit a doc request)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 🎗️ delete both content types in storeframework account after PR got merged.
✅ 🎗️ sync FS + hCMS in vtex account.
What's the purpose of this pull request?
This pull request handles multiple global content types. Now the global sections are expected to have:
globalHeaderSectionsandglobalFooterSections.How it works?
Added
globalHeaderSectionsandglobalFooterSectionsglobalHeaderSections- injected before the Children section fromglobalSectionscontent type.globalHeaderFooter- injected after the Children section fromglobalSectionscontent type.All the pages now are fetching these content types if they exist and merging all global sections.
How to test it?
with the version of this PR in the starter:
vtex switch <account>globalHeaderSectionsandglobalFooterSectionscontent types, sync the hCMS with the command:yarn cms-sync. you can use the dry optionyarn cms-sync -d(just for tests before really sync).globalHeaderSectionsandglobalFooterSections.globalHeaderSectionsbefore the Children andglobalFooterSectionsafter the children.hCMS
Starters Deploy Preview
you can check the section in this preview
https://storeframework-cm652ufll028lmgv665a6xv0g-isf4taa08.b.vtex.app/
References
https://vtex.slack.com/archives/C02JMH9AYR1/p1738007781146059