Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: BreadcrumbList item using full store page URLs #2678

Closed
wants to merge 4 commits into from

Conversation

lucasfp13
Copy link
Contributor

What's the purpose of this pull request?

This PR intends to set item as full store's page URL (PLP and PDP) for BreadcrumbList's� item list elements.

How it works?

The collection and product data is built in @faststore/api. The breadcrumList attribute consists of item, name and position. The item is the pathname of that specific page, so it is in the relative path form.

We should use URL's absolute path, so we have to prepend the storeUrl (production domain) to a correct structured data.

How to test it?

Starters Deploy Preview

@lucasfp13 lucasfp13 requested a review from hellofanny February 10, 2025 19:14
@lucasfp13 lucasfp13 self-assigned this Feb 10, 2025
@lucasfp13 lucasfp13 requested a review from a team as a code owner February 10, 2025 19:14
@lucasfp13 lucasfp13 requested review from emersonlaurentino and removed request for a team February 10, 2025 19:14
@lucasfp13 lucasfp13 closed this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants