Skip to content

Commit

Permalink
feat: accept pr suggestion
Browse files Browse the repository at this point in the history
  • Loading branch information
lucasaarcoverde committed Nov 24, 2023
1 parent f8c256e commit ab3e0b6
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 6 deletions.
11 changes: 8 additions & 3 deletions packages/components/src/simple-table/simple-table-header.tsx
Original file line number Diff line number Diff line change
@@ -1,15 +1,20 @@
import type { Ref } from 'react'
import React from 'react'
import { TableHeader, TableHeaderCell, TableRow } from '../table'
import type { TableHeaderProps } from '../table'
import { flexRender } from '@tanstack/react-table'
import type { HeaderGroup } from '@tanstack/react-table'
import { IconArrowDown, IconArrowUp } from '@vtex/shoreline-icons'
import { forwardRef } from '@vtex/shoreline-utils'

export function SimpleTableHeader<T>(props: SimpleTableRowProps<T>) {
export const SimpleTableHeader = forwardRef(function SimpleTableHeader<T>(
props: SimpleTableRowProps<T>,
ref: Ref<HTMLDivElement>
) {
const { headers, children, ...otherProps } = props

return (
<TableHeader {...otherProps}>
<TableHeader {...otherProps} ref={ref}>
{headers.map((headerGroup) => (
<TableRow key={headerGroup.id}>
{headerGroup.headers.map((header) => (
Expand All @@ -35,7 +40,7 @@ export function SimpleTableHeader<T>(props: SimpleTableRowProps<T>) {
))}
</TableHeader>
)
}
})

export interface SimpleTableRowProps<T> extends TableHeaderProps {
headers: Array<HeaderGroup<T>>
Expand Down
11 changes: 8 additions & 3 deletions packages/components/src/simple-table/simple-table-row.tsx
Original file line number Diff line number Diff line change
@@ -1,17 +1,22 @@
import type { ReactNode } from 'react'
import type { ReactNode, Ref } from 'react'
import React, { Fragment } from 'react'
import { TableCell, TableRow, type TableRowProps } from '../table'
import { flexRender, type Row } from '@tanstack/react-table'
import type { NavigationTarget } from '../link-box/link-box-utils'
import { Clickable } from '../clickable'
import { LinkBox } from '../link-box'
import { forwardRef } from '@vtex/shoreline-utils'

export function SimpleTableRow<T>(props: SimpleTableRowProps<T>) {
export const SimpleTableRow = forwardRef(function SimpleTableRow<T>(
props: SimpleTableRowProps<T>,
ref: Ref<HTMLDivElement>
) {
const { row, id, rowClick, renderDetail, children, ...otherProps } = props

return (
<Fragment key={id}>
<TableRow
ref={ref}
selected={row.getIsSelected()}
expanded={row.getIsExpanded()}
{...otherProps}
Expand Down Expand Up @@ -68,7 +73,7 @@ export function SimpleTableRow<T>(props: SimpleTableRowProps<T>) {
)}
</Fragment>
)
}
})

export interface SimpleTableRowProps<T> extends TableRowProps {
row: Row<T>
Expand Down

0 comments on commit ab3e0b6

Please sign in to comment.