Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tokens package #1282

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Tokens package #1282

merged 1 commit into from
Nov 21, 2023

Conversation

matheusps
Copy link
Contributor

Summary

This PR does mainly 3 things:

  1. Create a package that exports all shoreline tokens for ease of use.
  2. Import the tokens on storybook a single time
  3. Import the CSS of each component and bundle using esbuild.

It may help to solve: #1261

Examples

Using tokens

Just import the package:

import '@vtex/shoreline-tokens/styles'

In CSS

@import '@vtex/shoreline-tokens/dist/styles.min.css'

@matheusps matheusps self-assigned this Nov 21, 2023
@matheusps matheusps requested a review from a team as a code owner November 21, 2023 16:43
@vercel Vercel
Copy link

vercel bot commented Nov 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shoreline-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 4:44pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
admin-ui-docs ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2023 4:44pm

marcelovicentegc
marcelovicentegc reviewed Nov 21, 2023
View reviewed changes
.storybook/themeDecorator.jsx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell yeah

marcelovicentegc
marcelovicentegc reviewed Nov 21, 2023
View reviewed changes
packages/components/src/action/stories/action.stories.tsx
@@ -1,4 +1,3 @@
import '../../../dist/styles.min.css'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bye bye

marcelovicentegc
marcelovicentegc approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@marcelovicentegc marcelovicentegc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@marcelovicentegc
Copy link
Member

marcelovicentegc commented Nov 21, 2023 •
edited
Loading

Let's just wait to check how Storybook looks before merging!!!!

@matheusps matheusps merged commit 1017f5d into main Nov 21, 2023
2 checks passed
@matheusps matheusps deleted the feature/tokens branch November 21, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelovicentegc marcelovicentegc marcelovicentegc approved these changes

Assignees

@matheusps matheusps

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matheusps @marcelovicentegc