fix(filter-clear): disable clear button when value is empty array #2067
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Solves this issue: #2064
Now multi select filter's clear button renders as disabled correctly when the value is an empty array, not only with empty strings (or other falsy values). The behaviour is now the same for single item (radio) or multiple item (checkbox) filters.
Examples
This behavior can be observed in the
Filter
Show
story:This multiselect filter:
renders the clear button as disabled when it has no value and nothing is selected
and still renders it enabled when an item is selected
or if it has an item already applied
While this single selection filter:
still renders as it did before, as expected, here disabled with no value
here enabled with an item selected
and here enabled with an item already applied