Skip to content

chore: remove import.meta.server in template #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2024
Merged

chore: remove import.meta.server in template #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions content/2.concepts/5.middleware/.template/files/middleware/hello-foo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export default defineNuxtRouteMiddleware(() => {
console.log('hello-foo')
})
6 changes: 3 additions & 3 deletions content/2.concepts/5.middleware/.template/solutions/middleware/my-middleware.global.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
export default defineNuxtRouteMiddleware((to) => {
// FIXME: import . meta . server が置換されてしまう
if (import.meta.server)
// import.meta を利用した分岐でも OK
if (!window?.localStorage)
return

const isSignedIn = JSON.parse(localStorage.getItem('isSignedIn') || 'false')
const isSignedIn = JSON.parse(window.localStorage.getItem('isSignedIn') || 'false')

if (!isSignedIn && to.path !== '/') {
return navigateTo('/')
Expand Down
6 changes: 0 additions & 6 deletions content/2.concepts/5.middleware/.template/solutions/pages/foo.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
<script setup lang="ts">
definePageMeta({
middleware: ['hello-foo'],
})
</script>

<template>
<h1>Foo</h1>
<NuxtLink to="/">
Expand Down
5 changes: 3 additions & 2 deletions content/2.concepts/5.middleware/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,12 @@ definePageMeta({

これらのミドルウェアは、クライアント上でのナビゲーション時はもちろん、SSR または SSG でのページ生成時にもサーバーサイドで実行されます。\
ミドルウェアでローカルストレージなどのクライアントサイドの API を使用する場合は、クライアントサイドのみで実行されるようにする必要があります。\
`import.meta` を使うことで実行している環境を判定することができます。サーバーサイドでの実行スキップする場合は `import.meta.server` を利用します。
`import.meta` を使うことで実行している環境を判定することができます。
サーバーサイドでの実行スキップする場合は `import.meta.server` を利用します。

```ts
export default defineNuxtRouteMiddleware((to) => {
// skip middleware on server
// skip middleware on server (if (import.meta.client) { ... } でも同様)
if (import.meta.server)
return

Expand Down