fix(runtime-core): type ExposedKeys removed defined properties on com…

[akotulu]

Fixes typo made in pull request #3399.

IDEs using Vue language service with TypeScript support will have all the local component variables displayed as red with an error Vue: X does not exist on type. ExposedKeys will compare empty string ('') to extend Exposed type which will always fail cause builtin string can't extend custom class.

Tested with:
PHPStrom 2024.3.1.1
TypeScript 5.7.3
Vue LS 2.2.0

[jh-leong]

This change will break the existing test case in packages-private/dts-test/defineComponent.test-d.tsx. You can verify this by running pnpm run test-dts.

By the way, could you provide a test case or a minimal reproduction to clarify the issue this PR is addressing? Thanks!

[github-actions]

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	100 kB	38 kB	34.3 kB
vue.global.prod.js	158 kB	57.8 kB	51.5 kB

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	46.4 kB	18.2 kB	16.6 kB
createApp	54.3 kB	21.2 kB	19.3 kB
createSSRApp	58.5 kB	22.9 kB	20.9 kB
defineCustomElement	59.2 kB	22.8 kB	20.7 kB
overall	68.4 kB	26.3 kB	24 kB

[pkg-pr-new]

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12697

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12697

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12697

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12697

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12697

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12697

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12697

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12697

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12697

vue

npm i https://pkg.pr.new/vue@12697

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12697

commit: 980cd03

[DC240]

This change will break the existing test case in packages-private/dts-test/defineComponent.test-d.tsx. You can verify this by running pnpm run test-dts.

By the way, could you provide a test case or a minimal reproduction to clarify the issue this PR is addressing? Thanks!

I can confirm this issue using Webstorm LTS 2024.2.5 Build #WS-242.24807.6
I created a reproduction repo: https://github.com/DC240/12697-runtime-core-error-reproduction

It is however, only the case if I'm using class based components using vue-facing-decorator. Using the composition API, the component resolves correctly. We have a lot of older projects at our company for which there is no budget to convert them to composition API, so for us it is a pretty common and annoying problem.

[akotulu]

It took whole weekend to figure out where this issue with Intellij ideas came from. I will look at the tests when I have time again. Probably end of the week.

[DC240]

It took whole weekend to figure out where this issue with Intellij ideas came from. I will look at the tests when I have time again. Probably end of the week.

Do you have any updates on this by any chance?

[edison1105]

this PR breaks https://github.com/akotulu/core/blob/980cd03c97924530bb58444bd4bf1267d121c0ee/packages-private/dts-test/defineComponent.test-d.tsx#L1616

[akotulu]

Fixed the test.

[netlify]

❌ Deploy Preview for vue-next-template-explorer failed. Why did it fail? →

Name	Link
🔨 Latest commit	d106429
🔍 Latest deploy log	https://app.netlify.com/sites/vue-next-template-explorer/deploys/67a47957cdb889000811536d

[edison1105]

this change is not proper, both a and b should be exposed, see line 1618.

[akotulu]

Trying to reproduce the issue weeks later fails with or without the modification. Language server doesn't display the errors anymore. There hasn't been any PHPStorm update, kinda of magic what is going on. Also thanks for pointing out the test was invalid, should have read the docks more carefully beforehand.

[dantec20]

I would like to ask if this issue can be reopened since the issue still persists. The Github repo I created can be used as a reference, see my comment below. Also for reference: this screenshot is from one of my existing projects:

This change will break the existing test case in packages-private/dts-test/defineComponent.test-d.tsx. You can verify this by running pnpm run test-dts.
By the way, could you provide a test case or a minimal reproduction to clarify the issue this PR is addressing? Thanks!

I can confirm this issue using Webstorm LTS 2024.2.5 Build #WS-242.24807.6 I created a reproduction repo: https://github.com/DC240/12697-runtime-core-error-reproduction

It is however, only the case if I'm using class based components using vue-facing-decorator. Using the composition API, the component resolves correctly. We have a lot of older projects at our company for which there is no budget to convert them to composition API, so for us it is a pretty common and annoying problem.

[akotulu]

Em, well my so called fix didn't pass the test but the IDE issue went away with latest version of PHPStorm so I have no clue what could be wrong.

[dantec20]

My colleagues and I just figured out that the issue disappears when you don't put export default [classname] extends Vue on one line.

If you do it like this, all component errors are fixed:

@Component({})
class MyClassName extends Vue {
    // .....
}

export default MyClassName;```

Not sure what's causing this.