Skip to content

fix(compiler-ssr): resolve tag name from _attrs in transition group #12829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/compiler-ssr/__tests__/ssrTransitionGroup.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,18 @@ describe('transition-group', () => {
"const { ssrRenderList: _ssrRenderList } = require("vue/server-renderer")

return function ssrRender(_ctx, _push, _parent, _attrs) {
const _tag = (_attrs && typeof _attrs.tag === 'string') ? _attrs.tag : ''
if (_tag) {
_push(\`<\${_tag}>\`)
}
_push(\`<!--[-->\`)
_ssrRenderList(_ctx.list, (i) => {
_push(\`<div></div>\`)
})
_push(\`<!--]-->\`)
if (_tag) {
_push(\`</\${_tag}>\`)
}
}"
`)
})
Expand Down Expand Up @@ -114,6 +121,10 @@ describe('transition-group', () => {
"const { ssrRenderList: _ssrRenderList } = require("vue/server-renderer")

return function ssrRender(_ctx, _push, _parent, _attrs) {
const _tag = (_attrs && typeof _attrs.tag === 'string') ? _attrs.tag : ''
if (_tag) {
_push(\`<\${_tag}>\`)
}
_push(\`<!--[-->\`)
_ssrRenderList(10, (i) => {
_push(\`<div></div>\`)
Expand All @@ -125,6 +136,9 @@ describe('transition-group', () => {
_push(\`<div>ok</div>\`)
}
_push(\`<!--]-->\`)
if (_tag) {
_push(\`</\${_tag}>\`)
}
}"
`)
})
Expand Down
3 changes: 2 additions & 1 deletion packages/compiler-ssr/src/ssrCodegenTransform.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import {
type CompilerError,
type CompilerOptions,
ElementTypes,
type ExpressionNode,
type IfStatement,
type JSChildNode,
NodeTypes,
Expand Down Expand Up @@ -84,7 +85,7 @@ export interface SSRTransformContext {
onError: (error: CompilerError) => void
helper<T extends symbol>(name: T): T
pushStringPart(part: TemplateLiteral['elements'][0]): void
pushStatement(statement: IfStatement | CallExpression): void
pushStatement(statement: IfStatement | CallExpression | ExpressionNode): void
}

function createSSRTransformContext(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@ import {
NodeTypes,
type TransformContext,
buildProps,
createBlockStatement,
createCallExpression,
createIfStatement,
createSimpleExpression,
findProp,
} from '@vue/compiler-dom'
import { SSR_RENDER_ATTRS } from '../runtimeHelpers'
Expand Down Expand Up @@ -112,7 +115,38 @@ export function ssrProcessTransitionGroup(
context.pushStringPart(`</${tag.value!.content}>`)
}
} else {
// _attrs may contain tag property
const hasFallthroughAttrs = node.props.some(
p =>
p.type === NodeTypes.DIRECTIVE &&
p.name === 'bind' &&
p.exp &&
p.exp.type === NodeTypes.SIMPLE_EXPRESSION &&
p.exp.content === '_attrs',
)
if (hasFallthroughAttrs) {
context.pushStatement(
createSimpleExpression(
`const _tag = (_attrs && typeof _attrs.tag === 'string') ? _attrs.tag : ''`,
),
)
context.pushStatement(
createIfStatement(
createSimpleExpression('_tag'),
createBlockStatement([createSimpleExpression('_push(`<${_tag}>`)')]),
),
)
}
// fragment
processChildren(node, context, true, true, true)

if (hasFallthroughAttrs) {
context.pushStatement(
createIfStatement(
createSimpleExpression('_tag'),
createBlockStatement([createSimpleExpression('_push(`</${_tag}>`)')]),
),
)
}
}
}
16 changes: 16 additions & 0 deletions packages/server-renderer/__tests__/ssrAttrFallthrough.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,4 +75,20 @@ describe('ssr: attr fallthrough', () => {
`<div id="foo" class="bar baz"></div>`,
)
})

// #12827
test('with transition-group tag name', async () => {
expect(
await renderToString(
createApp({
components: {
one: {
template: `<TransitionGroup><slot/></TransitionGroup>`,
},
},
template: `<one tag="div"><p v-for="i in 2">{{i}}</p></one>`,
}),
),
).toBe(`<div><!--[--><p>1</p><p>2</p><!--]--></div>`)
})
})