Skip to content

fix(runtime-vapor): pass plain object props to createVNode during vdom interop #13382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edison1105 merged 3 commits into from
Nov 6, 2025
Merged

fix(runtime-vapor): pass plain object props to createVNode during vdom interop #13382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
398c16f
fix(vapor): special handling vapor props in vdom interop
edison1105 May 26, 2025
ae09cce
chore: Merge branch 'minor' into edison/fix/vdomInteropWithProps
edison1105 Nov 6, 2025
c89e915
[autofix.ci] apply automated fixes
autofix-ci[bot] Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions packages/runtime-vapor/__tests__/vdomInterop.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,28 @@ describe('vdomInterop', () => {

expect(html()).toBe('foo')
})

test('should handle class prop when vapor renders vdom component', () => {
const VDomChild = defineComponent({
setup() {
return () => h('div', { class: 'foo' })
},
})

const VaporChild = defineVaporComponent({
setup() {
return createComponent(VDomChild as any, { class: () => 'bar' })
},
})

const { html } = define({
setup() {
return () => h(VaporChild as any)
},
}).render()

expect(html()).toBe('<div class="foo bar"></div>')
})
})

describe('v-model', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/runtime-vapor/src/vdomInterop.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ function createVDOMComponent(
const frag = new VaporFragment([])
const vnode = (frag.vnode = createVNode(
component,
rawProps && new Proxy(rawProps, rawPropsProxyHandlers),
rawProps && extend({}, new Proxy(rawProps, rawPropsProxyHandlers)),
Copy link
Member Author

@edison1105 edison1105 Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass a plain object instead of a Proxy one

Copy link
Member Author

@edison1105 edison1105 Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another solution is to add a set trap to rawPropsProxyHandlers

))
const wrapper = new VaporComponentInstance(
{ props: component.props },
Expand Down
Loading