Skip to content

feat!: make type-check command more comprehensive #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
haoqunjiang wants to merge 1 commit into from
Closed

feat!: make type-check command more comprehensive #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion template/config/typescript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"scripts": {
"build": "run-p type-check build-only",
"build-only": "vite build",
"type-check": "vue-tsc --noEmit"
"type-check": "run-p type-check:*"
},
"devDependencies": {
"@types/node": "^16.11.65",
Expand Down
4 changes: 4 additions & 0 deletions template/tsconfig/base/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
{
"scripts": {
"type-check:app": "vue-tsc --noEmit",
"type-check:config": "vue-tsc --noEmit -p tsconfig.config.json --composite false"
},
"devDependencies": {
"@vue/tsconfig": "^0.1.3"
}
Expand Down
4 changes: 3 additions & 1 deletion template/tsconfig/cypress-ct/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
{
"scripts": {
"type-check": "vue-tsc --noEmit -p tsconfig.cypress-ct.json --composite false"
"type-check": "run-p type-check:*",
"type-check:app": "vue-tsc --noEmit -p tsconfig.app.json --composite false",
"type-check:cypress-ct": "vue-tsc --noEmit -p tsconfig.cypress-ct.json --composite false"
}
}
4 changes: 2 additions & 2 deletions template/tsconfig/cypress-ct/tsconfig.cypress-ct.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
"extends": "./tsconfig.app.json",
"include": [
"env.d.ts",
"src/**/*",
"src/**/*.vue",
"src/**/__tests__/**/*",
Copy link
Member Author

@haoqunjiang haoqunjiang Oct 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to work in scenarios like #55 …

"src/**/__tests__/**/*.vue",
"cypress/support/component.*",
"cypress/support/commands.ts"
],
Expand Down
4 changes: 3 additions & 1 deletion template/tsconfig/vitest/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
{
"scripts": {
"type-check": "vue-tsc --noEmit -p tsconfig.vitest.json --composite false"
"type-check": "run-p type-check:*",
"type-check:app": "vue-tsc --noEmit -p tsconfig.app.json --composite false",
"type-check:vitest": "vue-tsc --noEmit -p tsconfig.vitest.json --composite false"
},
"devDependencies": {
"@types/jsdom": "^20.0.0"
Expand Down
1 change: 1 addition & 0 deletions template/tsconfig/vitest/tsconfig.vitest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"extends": "./tsconfig.app.json",
"include": ["env.d.ts", "src/**/__tests__/**/*", "src/**/__tests__/**/*.vue"],
"exclude": [],
"compilerOptions": {
"composite": true,
Expand Down