Skip to content
This repository was archived by the owner on Aug 8, 2022. It is now read-only.

Fixed scroll bugs at encoded title #228

Merged
merged 2 commits into from
Oct 25, 2020
Merged

Fixed scroll bugs at encoded title #228

merged 2 commits into from
Oct 25, 2020

Conversation

Jinjiang
Copy link
Member

@Jinjiang Jinjiang commented Oct 25, 2020

Description of Problem

修复中文标题定位和滚动时的报错

Proposed Solution

通过 patch-package 临时修复了 vuepress 中的问题。后续 vuepress 如果更新之后,这个 patch 可以随时再去掉。

Additional Information

#5

另外我发现本地开发模式下和最终 build 出来的版本在行为上有差异。本地开发模式下滚动和锚点定位依然有问题,但最终 build 出来是正常的。

@Jinjiang Jinjiang requested a review from veaba October 25, 2020 15:00
@veaba veaba requested a review from Justineo October 25, 2020 15:18
@veaba
Copy link
Member

veaba commented Oct 25, 2020

我分别在本地和服务器都搭建一套来测试下效果。
👍

@Jinjiang
Copy link
Member Author

@veaba 线上的效果应该可以直接看这里:https://deploy-preview-228--vue-docs-next-zh-cn.netlify.app/

@veaba
Copy link
Member

veaba commented Oct 25, 2020

上面链接巨卡无比。
dev 环境下,没有生效,是不是将文件存在内存中没有替换过来所致,但问题也不大吧。
先合并吧,后续有方案再回顾下。
我记到 project 里。

Copy link
Member

@veaba veaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

@veaba veaba merged commit b0d4f58 into master Oct 25, 2020
@Jinjiang Jinjiang deleted the jinjiang/fix/scroll branch October 26, 2020 01:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants