Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for typescript with target of es5 #193

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 49 additions & 40 deletions packages/babel-sugar-inject-h/src/index.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import syntaxJsx from '@babel/plugin-syntax-jsx'
import syntaxJsx from "@babel/plugin-syntax-jsx";

/**
* Check if first parameter is `h`
Expand All @@ -7,9 +7,9 @@ import syntaxJsx from '@babel/plugin-syntax-jsx'
* @returns boolean
*/
const firstParamIsH = (t, path) => {
const params = path.get('params')
return params.length && t.isIdentifier(params[0]) && params[0].node.name === 'h'
}
const params = path.get("params");
return params.length && t.isIdentifier(params[0]) && params[0].node.name === "h";
};

/**
* Check if body contains JSX
Expand All @@ -20,17 +20,17 @@ const firstParamIsH = (t, path) => {
const hasJSX = (t, path) => {
const JSXChecker = {
hasJSX: false,
}
};
path.traverse(
{
JSXElement() {
this.hasJSX = true
this.hasJSX = true;
},
},
JSXChecker,
)
return JSXChecker.hasJSX
}
JSXChecker
);
return JSXChecker.hasJSX;
};

/**
* Check if is inside a JSX expression
Expand All @@ -40,45 +40,54 @@ const hasJSX = (t, path) => {
*/
const isInsideJSXExpression = (t, path) => {
if (!path.parentPath) {
return false
return false;
}
if (t.isJSXExpressionContainer(path.parentPath)) {
return true
return true;
}
return isInsideJSXExpression(t, path.parentPath);
};

/**
* generate code after inject h
* @param {*} t
* @param {*} path
* @param {*} isRender
* @returns void
*/
const generateCode = (t, path, isRender) => {
if (firstParamIsH(t, path) || !hasJSX(t, path) || isInsideJSXExpression(t, path)) {
return;
}
return isInsideJSXExpression(t, path.parentPath)
}

export default babel => {
const t = babel.types
path.get("body").unshiftContainer("body", t.variableDeclaration("const", [t.variableDeclarator(t.identifier("h"), isRender ? t.memberExpression(t.identifier("arguments"), t.numericLiteral(0), true) : t.memberExpression(t.thisExpression(), t.identifier("$createElement")))]));
};

export default (babel) => {
const t = babel.types;

return {
inherits: syntaxJsx,
visitor: {
Program(path1) {
path1.traverse({
'ObjectMethod|ClassMethod'(path) {
if (firstParamIsH(t, path) || !hasJSX(t, path) || isInsideJSXExpression(t, path)) {
return
"ObjectMethod|ClassMethod"(path) {
const isRender = path.node.key.name === "render";
generateCode(t, path, isRender);
},
ObjectProperty(path) {
const isRender = "render" === path.node.key.name;
const isFunctionExpression = "FunctionExpression" === path.node.value.type;
if (isFunctionExpression && isRender) {
path.traverse({
FunctionExpression(path) {
generateCode(t, path, true);
},
});
}

const isRender = path.node.key.name === 'render'

path
.get('body')
.unshiftContainer(
'body',
t.variableDeclaration('const', [
t.variableDeclarator(
t.identifier('h'),
isRender
? t.memberExpression(t.identifier('arguments'), t.numericLiteral(0), true)
: t.memberExpression(t.thisExpression(), t.identifier('$createElement')),
),
]),
)
}
})
}
},
});
},
},
}
}
};
};