Skip to content

test: add tests for #3592#3595

Merged
johnsoncodehk merged 6 commits intovuejs:masterfrom
so1ve-forks:fix/issue-3592
Oct 8, 2023
Merged

test: add tests for #3592#3595
johnsoncodehk merged 6 commits intovuejs:masterfrom
so1ve-forks:fix/issue-3592

Conversation

@so1ve
Copy link
Member

@so1ve so1ve commented Sep 26, 2023

close #3595

I'm not sure if this is the right fix, because I found another issue in vue core: vuejs/core#9296 which might be the root cause of this issue

@johnsoncodehk
Copy link
Member

johnsoncodehk commented Sep 26, 2023

Yes, it's a Vue TS problem, we do a hack for this (bypassDefineComponent in code). The issue has been fixed by db8857b, could you update the PR to add a test?

@so1ve so1ve marked this pull request as ready for review September 26, 2023 11:40
@so1ve
Copy link
Member Author

so1ve commented Sep 26, 2023

I've updated this PR!

@so1ve so1ve changed the title fix: fill ctx with props test: add tests for #3595 Sep 26, 2023
@johnsoncodehk johnsoncodehk force-pushed the master branch 2 times, most recently from 52d7be2 to a61bad7 Compare September 26, 2023 14:32
@johnsoncodehk
Copy link
Member

We also need to refactor the current vue-tsc test, otherwise this test will not run.

I think the current test directory is a bit confusing, and I want to sort it out first.

@johnsoncodehk johnsoncodehk merged commit 4823ee0 into vuejs:master Oct 8, 2023
@johnsoncodehk johnsoncodehk changed the title test: add tests for #3595 test: add tests for #3592 Oct 8, 2023
johnsoncodehk added a commit that referenced this pull request Oct 8, 2023
Co-authored-by: Johnson Chu <johnsoncodehk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments