Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: text token type in V_EXPRESSION_DATA state #257

Merged
merged 1 commit into from
Apr 5, 2025
Merged

fix: text token type in V_EXPRESSION_DATA state #257

merged 1 commit into from
Apr 5, 2025
+567 −2

Conversation

woongsikchoi
Copy link
Contributor

This PR fixes the problem that HTMLRCDataText and HTMLRawText token types were reversed inside V_EXPRESSION_DATA state.

@ota-meshi
Copy link
Member

I'm not sure what this PR solves.
Could you please open an issue and explain the problem in more detail? Also, please share a repo where we can reproduce the problem.

@ws807 ws807 mentioned this pull request Apr 4, 2025
Open
4 tasks
@ws807
Copy link
Contributor

ws807 commented Apr 4, 2025

I have opened issue #261 explaining the problem in more detail with a reproduction step.
However, I could not find any visible problems caused by this issue.

ota-meshi
ota-meshi requested changes Apr 5, 2025
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the explanation and this PR!

@ota-meshi ota-meshi merged commit d09047a into vuejs:master Apr 5, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ws807 ws807 ws807 left review comments

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@woongsikchoi @ota-meshi @ws807