This repository was archived by the owner on Jul 19, 2025. It is now read-only.
fix(runtime-vapor): supports the use of slots with v-if#267
Open
yangxiuxiu1115 wants to merge 7 commits into
Open
fix(runtime-vapor): supports the use of slots with v-if#267yangxiuxiu1115 wants to merge 7 commits into
yangxiuxiu1115 wants to merge 7 commits into
Conversation
✅ Deploy Preview for vapor-template-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for vapor-repl ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size ReportBundles
Usages
|
|
commit: @vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-shared
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
@vue/vapor
|
LittleSound
reviewed
Aug 8, 2024
| instance.scope.off() | ||
| currentInstance = prev | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
I am concerned this change may cause issues because:
- The
setCurrentInstancewill setinstance.scope.on()internally andinstance.scope.off()when calling reset, but as an internal Function, this hidden behavior is not very intuitive- Not all situations that need to set
currentInstanceneed to setinstance.scope.on()at the same time, and this behavior is wrong inrenderEffect.
related: #174
sxzz
force-pushed
the
main
branch
2 times, most recently
from
2bf3c5e to
8ea6e4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.