Skip to content

Conversation

@DaKoala
Copy link
Contributor

@DaKoala DaKoala commented Apr 24, 2019

Close #8855

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Add the feature required in issue #8855

@yyx990803
Copy link
Member

Great - could you rebase against dev to fix CI please?

@DaKoala
Copy link
Contributor Author

DaKoala commented Apr 25, 2019

Great - could you rebase against dev to fix CI please?

I have rebased the branch and passed all tests.

@posva posva changed the title feat: check if a tag is already in window.customElements (#8855) feat: check if a tag is already in window.customElements Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check if tag is already in the window.customElements registry on top of checking config ignoredElements

9 participants