Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing args check in commands #506

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Added missing args check in commands #506

merged 1 commit into from
Mar 4, 2025

Conversation

kanha-gupta
Copy link
Contributor

@kanha-gupta kanha-gupta commented Jan 26, 2025 •
edited
Loading

Description

Added missing args check in following commands :

  1. container-registry credentials docker
  2. kubernetes list, kubernetes start
  3. database user list, database topic list, database quota list

Related Issues

Fixes #498
Fixes #497

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@github-actions GitHub Actions
Copy link

Unit Tests and Coverage

Show Output 
	github.com/vultr/vultr-cli/v3		coverage: 0.0% of statements

Pusher: @kanha-gupta, Action: pull_request_target

@optik-aper optik-aper assigned optik-aper and unassigned optik-aper Mar 4, 2025
@optik-aper optik-aper added the bug Something isn't working label Mar 4, 2025
optik-aper
optik-aper approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@optik-aper optik-aper merged commit 22a8046 into vultr:master Mar 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@optik-aper optik-aper optik-aper approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@kanha-gupta @optik-aper