Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the algorithms suite. #127

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Clean up the algorithms suite. #127

merged 5 commits into from
Oct 28, 2024

Conversation

aljones15
Copy link
Contributor

@aljones15 aljones15 commented Oct 24, 2024

  • create test to ensure suite runs with all suites.
    Features:
  1. puts proofChain tests behind features.proofChain
  2. puts domain & challenge tests behind features.authentication
  3. exports the algorithms suite
  4. adds test support for algorithms suite for all existing suites

@aljones15 aljones15 self-assigned this Oct 24, 2024
@aljones15 aljones15 changed the title Clean up the algorithms assertion. Clean up the algorithms suite. Oct 24, 2024
@aljones15 aljones15 requested review from BigBlueHat and PatStLouis and removed request for BigBlueHat October 24, 2024 18:10
@aljones15 aljones15 marked this pull request as ready for review October 24, 2024 18:11
this.matrix = true;
this.report = true;
this.rowLabel = 'Test Name';
this.columnLabel = 'Verifier';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are hardcoding 'Verifier' here, shouldn't this be called describeVerifier?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch here as the tests use both issuer and verifier this should be changed to implementation probably.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should have been fixed by an line comment.

@PatStLouis
Copy link
Collaborator

when you say "create test to ensure suite runs with all suites", can you explain a bit more what does this mean exactly and the purpose? I'm not sure I understand it Is it to make sure these test suites are compatible with all cryptosuites? There's a test described as "should issue all suites", is that referring to an implementation or the vc-generator issuer?

@aljones15
Copy link
Contributor Author

when you say "create test to ensure suite runs with all suites", can you explain a bit more what does this mean exactly and the purpose? I'm not sure I understand it Is it to make sure these test suites are compatible with all cryptosuites? There's a test described as "should issue all suites", is that referring to an implementation or the vc-generator issuer?

https://github.com/w3c-ccg/data-integrity-test-suite-assertion/pull/127/files#diff-c881620c2d55af0c2c4e4faa1f54c53bf9a946370ec4a40a39de3402cbdac73e

There is an internal suite that runs all data integrity suites against the algorithms suite to ensure they run.

@aljones15 aljones15 merged commit 433c38d into main Oct 28, 2024
1 of 2 checks passed
@aljones15 aljones15 deleted the export-algorithms-suite branch October 28, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants