-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up the algorithms suite. #127
Conversation
suites/algorithms.js
Outdated
this.matrix = true; | ||
this.report = true; | ||
this.rowLabel = 'Test Name'; | ||
this.columnLabel = 'Verifier'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are hardcoding 'Verifier' here, shouldn't this be called describeVerifier
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch here as the tests use both issuer and verifier this should be changed to implementation
probably.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should have been fixed by an line comment.
when you say "create test to ensure suite runs with all suites", can you explain a bit more what does this mean exactly and the purpose? I'm not sure I understand it Is it to make sure these test suites are compatible with all cryptosuites? There's a test described as "should issue all suites", is that referring to an implementation or the vc-generator issuer? |
There is an internal suite that runs all data integrity suites against the algorithms suite to ensure they run. |
Features:
features.proofChain
features.authentication