-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a recommendation section and a security section for payload sizes #445
Open
PatStLouis
wants to merge
2
commits into
main
Choose a base branch
from
437-payload-sizes-directves
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -719,6 +719,12 @@ <h3>Handling Unknown Options and Data</h3> | |||||
Implementations MUST throw an error if an endpoint receives data, options, or option values that it | ||||||
does not understand or know how to process. | ||||||
</p> | ||||||
<h4>Payload Sizes</h4> | ||||||
<p>Implementations are encouraged to pay attention to the payload sizes of the Verifiable Credentials they issue.</p> | ||||||
<p>Presentations can bundle a large volume of credentials, resulting in a higher request size than anticipated. This heightens the risk of interoperability issues.</p> | ||||||
<p>A default maximum size of 10MB per Verifiable Credential is recommended as an interoperability baseline, with the possibility of configuring a larger size if required. The configuration should be detailed at an instance level. | ||||||
This also accounts for the 16MB size limit of most document-based storage database solutions.</p> | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
<p>By default, large binary values should be linked to and a hash included (unless there is a privacy reason for not doing so).</p> | ||||||
</section> | ||||||
<section> | ||||||
<h3>API Component Overview</h3> | ||||||
|
@@ -1452,6 +1458,11 @@ <h3>Deletion</h3> | |||||
</p> | ||||||
</section> | ||||||
|
||||||
<section> | ||||||
<h3>Payload Sizes</h3> | ||||||
<p>Larger transactions can trigger DoS incidents. It's recommended to configure the payload size accepted by endpoints at an instance level.</p> | ||||||
</section> | ||||||
|
||||||
</section> | ||||||
|
||||||
<section class="appendix"> | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a higher request size
?Is this not
a higher { result | return | presentation | something-else } size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The group discussed this on the 2025-02-18: @dlongley noted that we are talking about the request size... client posting VP with lots of credentials in it and that's what's being checked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.