Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grid and table properties practice: Fix misplaced greater than symbol in code sample #3194

Merged
merged 2 commits into from
Mar 18, 2025

Conversation

maeldebon
Copy link
Contributor

@maeldebon maeldebon commented Dec 17, 2024


WAI Preview Link (Last built on Tue, 25 Feb 2025 21:42:24 GMT).

@mcking65 mcking65 changed the title Fix misplaced chevron in grid and tables best practices grid and table properties practice: Fix misplaced greater than symbol in code sample Jan 14, 2025
@mcking65 mcking65 added editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Practice Page Related to a page within the practices section of the APG Feedback Issue raised by or for collecting input from people outside APG task force labels Jan 14, 2025
Copy link
Member

@adampage adampage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this, @maeldebon!

During the review, I’ve discovered another occurrence of the same issue at lines 239–240. Could we trouble you to fix that one as part of this PR as well? cc: @mcking65

@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed PR 3194 - Grid and table properties practice editorial fix.

The full IRC log of that discussion <jugglinmike> Topic: PR 3194 - Grid and table properties practice editorial fix
<jugglinmike> github: https://github.com//pull/3194
<jugglinmike> Matt_King: The change in this pull request seems good
<jugglinmike> Matt_King: Adam noted that the problem exists elsewhere
<jugglinmike> Matt_King: It seems editorial because it's a misplaced ">" in the code example (not in executable code)
<jugglinmike> Matt_King: Adam said the change here is good. He asked the person who wrote the PR if they could fix it in the other place where the problem occurs
<jugglinmike> Matt_King: It's been over a week, though, so I'm wondering if anyone here would like to push the fix
<jugglinmike> howard-e: I can help out, though I notice that this patch is the author's first contribution to the project. It might be nice to give them a little more time
<jugglinmike> Matt_King: You're right, there's no rush here. Though if we push to their branch, they will still be recognized as a contributor
<jugglinmike> Matt_King: If the original contributor provides that fix before February 11th, great. If not, we'll have howard-e or someone else lend a hand on their branch

@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed PR 3194 - Missing symbol in grid and table properties practice.

The full IRC log of that discussion <jugglinmike> Topic: PR 3194 - Missing symbol in grid and table properties practice
<jugglinmike> github: https://github.com//pull/3194
<jugglinmike> mk: Adam_Page provided feedback, and we decided to wait to see if the pull request author would respond
<jugglinmike> mk: It seems we haven't received a response, yet
<jugglinmike> mk: It would be nice to merge this, though
<jugglinmike> mk: If it's possible to push a commit to this branch with the change that addresses Adam_Page's feedback, that would be ideal
<jugglinmike> Adam_Page: I can give it a shot

Copy link
Member

@adampage adampage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mcking65, I’ve just pushed up a commit to fix that lingering occurrence.

Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @maeldebon for this fix.

@mcking65 mcking65 merged commit b9ed31b into w3c:main Mar 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Feedback Issue raised by or for collecting input from people outside APG task force Practice Page Related to a page within the practices section of the APG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants