Custom properties highlights #11528
Merged
Custom properties highlights #11528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was resolved in w3c#11317, CSS Highlight Pseudos should allow custom property definitions within the rule itself, but take any missing custom properties from the originating element. This PR updates the spec to re-list custom properties as supported on highlights. Futhermore, it fixes the description of custom property inheritance that was wrong even for the prior version of the spec.
andruud
reviewed
Jan 24, 2025
Post review updates and also fix more problems with the highlight cascade text.
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jan 30, 2025
This is a workaround for the use case of custom properties defined and used in the same rule for ::selection pseudos. The use case arises from tooling, particularly Tailwind CSS, and it caused a stable regression when Highlight Inheritance was launched. This change restores the original behavior in that highlight pseudos can use custom properties defined in the highlight itself. The custom properties are not inherited through the highlight inheritance chain, so this change does not result in confusion about the source of custom properties when Highlight Inheritance is enabled: the properties still come from the originating element and then the highlight pseudo itself, never it's parent highlight. CSS Spec PR: w3c/csswg-drafts#11528 Fixed: 381125910 Change-Id: I0f89e6b8ad96d097ce1e2b39c179a270d472991f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6053860 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Stephen Chenney <[email protected]> Cr-Commit-Position: refs/heads/main@{#1413271}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 30, 2025
This is a workaround for the use case of custom properties defined and used in the same rule for ::selection pseudos. The use case arises from tooling, particularly Tailwind CSS, and it caused a stable regression when Highlight Inheritance was launched. This change restores the original behavior in that highlight pseudos can use custom properties defined in the highlight itself. The custom properties are not inherited through the highlight inheritance chain, so this change does not result in confusion about the source of custom properties when Highlight Inheritance is enabled: the properties still come from the originating element and then the highlight pseudo itself, never it's parent highlight. CSS Spec PR: w3c/csswg-drafts#11528 Fixed: 381125910 Change-Id: I0f89e6b8ad96d097ce1e2b39c179a270d472991f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6053860 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Stephen Chenney <[email protected]> Cr-Commit-Position: refs/heads/main@{#1413271}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 30, 2025
This is a workaround for the use case of custom properties defined and used in the same rule for ::selection pseudos. The use case arises from tooling, particularly Tailwind CSS, and it caused a stable regression when Highlight Inheritance was launched. This change restores the original behavior in that highlight pseudos can use custom properties defined in the highlight itself. The custom properties are not inherited through the highlight inheritance chain, so this change does not result in confusion about the source of custom properties when Highlight Inheritance is enabled: the properties still come from the originating element and then the highlight pseudo itself, never it's parent highlight. CSS Spec PR: w3c/csswg-drafts#11528 Fixed: 381125910 Change-Id: I0f89e6b8ad96d097ce1e2b39c179a270d472991f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6053860 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Stephen Chenney <[email protected]> Cr-Commit-Position: refs/heads/main@{#1413271}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 2, 2025
…udos, a=testonly Automatic update from web-platform-tests Allow custom properties in highlight pseudos This is a workaround for the use case of custom properties defined and used in the same rule for ::selection pseudos. The use case arises from tooling, particularly Tailwind CSS, and it caused a stable regression when Highlight Inheritance was launched. This change restores the original behavior in that highlight pseudos can use custom properties defined in the highlight itself. The custom properties are not inherited through the highlight inheritance chain, so this change does not result in confusion about the source of custom properties when Highlight Inheritance is enabled: the properties still come from the originating element and then the highlight pseudo itself, never it's parent highlight. CSS Spec PR: w3c/csswg-drafts#11528 Fixed: 381125910 Change-Id: I0f89e6b8ad96d097ce1e2b39c179a270d472991f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6053860 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Stephen Chenney <[email protected]> Cr-Commit-Position: refs/heads/main@{#1413271} -- wpt-commits: 184a7bf8907297dd81a6dec8632a63c0b0a843cc wpt-pr: 50379
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Feb 5, 2025
…udos, a=testonly Automatic update from web-platform-tests Allow custom properties in highlight pseudos This is a workaround for the use case of custom properties defined and used in the same rule for ::selection pseudos. The use case arises from tooling, particularly Tailwind CSS, and it caused a stable regression when Highlight Inheritance was launched. This change restores the original behavior in that highlight pseudos can use custom properties defined in the highlight itself. The custom properties are not inherited through the highlight inheritance chain, so this change does not result in confusion about the source of custom properties when Highlight Inheritance is enabled: the properties still come from the originating element and then the highlight pseudo itself, never it's parent highlight. CSS Spec PR: w3c/csswg-drafts#11528 Fixed: 381125910 Change-Id: I0f89e6b8ad96d097ce1e2b39c179a270d472991f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6053860 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Stephen Chenney <[email protected]> Cr-Commit-Position: refs/heads/main@{#1413271} -- wpt-commits: 184a7bf8907297dd81a6dec8632a63c0b0a843cc wpt-pr: 50379
fantasai
approved these changes
Feb 5, 2025
Applied all of the suggested changes. Learned some things too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CSS-Pseudo-4] Correct custom properties in highlights
As was resolved in #11317, CSS Highlight Pseudos should allow custom property definitions within the rule itself, but take any missing custom properties from the originating element.
This PR updates the spec to re-list custom properties as supported on highlights. Furthermore, it fixes the description of custom property inheritance that was wrong even for the prior version of the spec.