-
Notifications
You must be signed in to change notification settings - Fork 735
[css-color-4] Add display-p3-linear #12596 #12601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The sample code does not need to be updated as it already converts to and from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this up! I'm not a color space expert, but I've done an editorial pass.
@@ -3,6 +3,7 @@ Title: CSS Color Adjustment Module Level 1 | |||
Shortname: css-color-adjust | |||
Level: 1 | |||
Status: ED | |||
Prepare for TR: no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like it should be separated out?
@@ -4119,6 +4120,56 @@ The Predefined Display P3 Color Space: the ''display-p3'' keyword</h3> | |||
2d.color.space.p3.toDataURL.with.putImageData.html | |||
</wpt> | |||
|
|||
<h3 id="predefined-display-p3-linear"> | |||
The Predefined Linear-light Display P3 Color Space: the ''display-p3-linear'' keyword</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect "Linear-Light" and also "Keyword" if you are going for title casing.
@@ -4714,7 +4765,7 @@ Color Space for Interpolation</h3> | |||
Thus, different color spaces may be more appropriate for each interpolation use case. | |||
|
|||
* In some cases, the result of physically mixing two colored lights is desired. | |||
In that case, the CIE XYZ or srgb-linear color space is appropriate, because they are linear in light intensity. | |||
In that case, the CIE XYZ, display-p3-linear or srgb-linear color spaces are appropriate, because they are linear in light intensity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these be linked to their definition?
Draft for now until CSSWG resolution