-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 230: Update description of sh:pattern
behavior with IRI nodes
#231
base: gh-pages
Are you sure you want to change the base?
Conversation
Per discussion on Issues 228 and 230. References: * #228 * #230 Signed-off-by: Alex Nelson <[email protected]>
@@ -40,7 +40,7 @@ ex:TestShape | |||
rdf:type sh:ValidationResult ; | |||
sh:focusNode ex:Test ; | |||
sh:resultSeverity sh:Violation ; | |||
sh:sourceConstraintComponent sh:PatternConstraintComponent ; | |||
sh:sourceConstraintComponent sh:NodeKindConstraintComponent ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original was right, this is wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no objection with rolling this back, but I'd like the reasoning to be unambiguous from updates to the SHACL-Core document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think should be sh:PatternConstraintComponent
(which jena-shacl
passes).
Even if it were a blank node - so some kind of argument error - it is sh:sourceConstraintComponent
which is the constraint failing, not some kind of an error class.
We-all need to agree on process. We have one repo for many documents. Force-push may loose work on other documents. The We need a protected branch for the documents. |
Apologies, I never had intention of force-pushing the That effort might be moot if the patch'll be superseded, though. |
+1, besides a protected main/dev branch, what about having dedicated branches for each of the individual documents? e.g., one for shacl-core, shacl-sparql, shacl-inference, shacl-cs, ... ? @gkellogg How was this handled in the JSON-LD WG with its documents on framing etc.? edit: JSON-LD had multiple repos https://github.com/search?q=topic%3Ajson-ld-wg+org%3Aw3c&type=Repositories |
sounds like overkill |
This patch series will address update test results, and possibly other documentation, around
sh:pattern
and how it behaves against IRI nodes. E.g., there will be clarification on what should happen with use cases like this:I.e., should the
sh:sourceConstraintComponent
besh:PatternConstraintComponent
for violating the pattern (not starting withhttps
)?sh:NodeKindConstraint
for being an IRI node, even thoughsh:nodeKind
is not used in this shape?The intent of this PR is to at least close #230 , and possibly generate editor's draft revisions to cover use case 1 in #228 .
I suspect the working group needs to confirm whether this will be a backwards-compatible change.
I could also see SHACL-SHACL being updated to further constrain where
sh:pattern
can be used.Aside: This is also my first PR against this repo, so rules-of-the-road pointers would be appreciated, such as appropriate target branch.
ACKs are due to @afs, @tfrancart, and @tpluscode from conversation on #228 ; what's the appropriate
git log
tag to use?Cc:
?I'll force-push the first patch for the benefit of
git log
andgit blame
after guidance on ACKs.