scope algorithm: Delete same-origin-as-document check. #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was redundant, because a) the start_url is already checked to be same-origin-as-document, and b) the start_url is checked to be within scope of scope (which implies they are same-origin). Thus the scope is guaranteed to be same-origin as the document without this explicit check. This removes the document URL parameter to the scope algorithm. No normative changes.
|
@marcoscaceres from your Twitter it looks like you're busy for awhile. @kenchris maybe can take a look? Thanks. Check my logic: I don't think this changes anything. |
dominickng
approved these changes
Jun 15, 2018
kenchris
approved these changes
Jun 15, 2018
kenchris
pushed a commit
to kenchris/manifest
that referenced
this pull request
Sep 3, 2018
This was redundant, because a) the start_url is already checked to be same-origin-as-document, and b) the start_url is checked to be within scope of scope (which implies they are same-origin). Thus the scope is guaranteed to be same-origin as the document without this explicit check. This removes the document URL parameter to the scope algorithm. No normative changes. Work towards fixing w3c#668.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was redundant, because a) the start_url is already checked to be
same-origin-as-document, and b) the start_url is checked to be within
scope of scope (which implies they are same-origin). Thus the scope is
guaranteed to be same-origin as the document without this explicit
check.
This removes the document URL parameter to the scope algorithm.
No normative changes.
Work towards fixing #668.
Preview | Diff