Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject zero as a value for impression lifetime #86

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

apasel422
Copy link
Collaborator

@apasel422 apasel422 commented Feb 10, 2025

Fixes #81


Preview | Diff

@apasel422 apasel422 marked this pull request as ready for review February 10, 2025 13:47
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinthomson martinthomson merged commit 764f599 into w3c:main Feb 11, 2025
1 check passed
@apasel422 apasel422 deleted the issue-81 branch February 11, 2025 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throw when passed a 0 for lifetimeDays
2 participants