[Spec] Add browser bound keys privacy and security considerations. #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
stephenmcgruer
previously approved these changes
May 20, 2025
spec.bs
Outdated
| should be verified using the passkey (in addition to the BBK). The BBK provides | ||
| an additional signature not a replacement for the passkey signature. | ||
|
|
||
| An attacker posing as a merchant may attempt to substitute a [=browser |
There was a problem hiding this comment.
I think it's more useful to first describe the attack in its entirety, then say why it doesn't work:
- Drop the lines "However, the bank will ..." and "Here again, ..."
- Add a line about what this means, e.g. that the attacker has defeated the 'device bound' part of BBKs
- Then say "However, this attack is not feasible as ..."
There was a problem hiding this comment.
Rephrased, please take another look.
ianbjacobs
reviewed
May 22, 2025
ianbjacobs
reviewed
May 22, 2025
ianbjacobs
reviewed
May 22, 2025
ianbjacobs
reviewed
May 22, 2025
ianbjacobs
reviewed
May 22, 2025
ianbjacobs
reviewed
May 22, 2025
ianbjacobs
reviewed
May 22, 2025
ianbjacobs
reviewed
May 22, 2025
ianbjacobs
reviewed
May 22, 2025
ianbjacobs
reviewed
May 22, 2025
| Party=] in order to initiate SPC and the user must authenticate the transaction | ||
| using their passkey. Since accessing the BBK public key requires access to the | ||
| credential ID first, the BBK does not add any incremental tracking. | ||
|
|
There was a problem hiding this comment.
I think it could be useful to remind the reader here that the BBK is only available through SPC, and SPC necessarily involves a user interaction before the BBK is used.
There was a problem hiding this comment.
You raise a good point, Ian. I also noted that the BBK is available once on the initial passkey creation.
pejic
commented
May 22, 2025
| Party=] in order to initiate SPC and the user must authenticate the transaction | ||
| using their passkey. Since accessing the BBK public key requires access to the | ||
| credential ID first, the BBK does not add any incremental tracking. | ||
|
|
There was a problem hiding this comment.
You raise a good point, Ian. I also noted that the BBK is available once on the initial passkey creation.
ianbjacobs
approved these changes
May 22, 2025
stephenmcgruer
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds privacy and security considerations related to browser bound keys. See also #286 for the implementation.
Preview | Diff