Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update serialization steps for return value of "browsingContext.locateNodes" command to align with #623

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

lutien
Copy link
Contributor

@lutien lutien commented Dec 18, 2023

At the moment, the spec for "browsingContext.locateNodes" command(step 18) says that we should serialize the list of the nodes, which would mean that the response would look like:

{ type: “array”, handle: “handle id”, value: [{type: “node”, sharedId: “shared id”, …}, …]} }

Where, in the merged tests, the expectation output should look like:

[{type: “node”, sharedId: “shared id”, handle: “handle id”, …}, …]

That also looks like more something clients would expect. To achieve the output specified in the tests, we should rather serialize each node individually and push them in the list after.


Preview | Diff

@lutien lutien force-pushed the fix-locate-nodes-result-serialization branch from 84dea62 to 38ef6d6 Compare December 18, 2023 15:25
@lutien lutien marked this pull request as ready for review December 18, 2023 15:29
@lutien lutien requested review from jgraham and jrandolf-2 December 18, 2023 15:35
@jgraham jgraham merged commit 46d0bc1 into w3c:main Dec 18, 2023
4 checks passed
@lutien lutien deleted the fix-locate-nodes-result-serialization branch January 12, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants