Unsubscribe by attributes should check that all events and context ids exist in subscriptions #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/subscription-recover-errors
branch
from
e044d74 to
c06c363
Compare
OrKoN
force-pushed
the
orkon/subscription-recover-errors
branch
from
c06c363 to
636da25
Compare
OrKoN
force-pushed
the
orkon/subscription-recover-errors
branch
from
0e23a4c to
31c2fda
Compare
OrKoN
changed the title
index.bs
Outdated
| @@ -2107,6 +2136,11 @@ The [=remote end steps=] with |session| and |command parameters| are: | |||
|
|
|||
| 1. [=list/append=] |partial subscription| to |new subscriptions|. | |||
|
|
|||
| 1. If |matched events| does not equal |event names|, return [=error=] with [=error code=] [=invalid argument=]. | |||
|
|
|||
| 1. If |top-level traversable context ids| is not empty and |matched contexts| does not equal | |||
There was a problem hiding this comment.
Technically we can simply compare |matched contexts| and |top-level traversable context ids|, as for global subscriptions they are both empty, for non-global the latest is non-empty. But the current version makes the algo more readable.
sadym-chromium
approved these changes
Jan 10, 2025
sadym-chromium
approved these changes
Jan 10, 2025
|
@jgraham PTAL (this is another spec regression from my subscription ID refactoring that I discovered while actually working on the implementation, I believe this is the last one). |
jgraham
approved these changes
Jan 15, 2025
OrKoN
added a commit
that referenced
this pull request
Jan 17, 2025
…s exist in subscriptions (#847) * Unsubscribe by attributes should only match a subset of subscriptions * update algorithm * use infra for set comparison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #828 I also overlooked that removal of subscriptions should only apply if all unsubscribe attributes match existing subscription data. To remain backward compatible, this PR adds steps to account for that and cover the cases like the following:
For events:
For contexts:
Preview | Diff