-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: i18n-system-languages #569
base: main
Are you sure you want to change the base?
Changes from 3 commits
d078e45
7ed4c53
916f91d
30fbed6
1339056
b7781f4
ae8e4e2
0c352e8
15fde77
1bf297c
b9ab150
da34a81
6107700
38e9f39
4eb3df1
280efb5
90dec9b
1d995e9
89f08b3
76acf81
395c02e
07b64c9
e8ae3a9
7e3c88f
64b942d
42f71ae
7ac0a42
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,9 +48,12 @@ Language-related extensions and extensions wanting to match the locale of the op | |
"parameters": [], | ||
"returns_async": { | ||
"name": "callback", | ||
"parameters": [ | ||
{"name": "languages", "type": "array", "items": {"$ref": "LanguageCode"}, "description": "Array of LanguageCode"} | ||
] | ||
"parameters": [{ | ||
"name": "languages", | ||
"type": "array", | ||
"items": {"$ref": "LanguageCode"}, | ||
"description": "Array of LanguageCode" | ||
}] | ||
} | ||
} | ||
|
||
|
@@ -67,11 +70,14 @@ It would follow the following signature for [i18n.json](https://chromium.googles | |
"name": "getSystemUILanguage", | ||
"type": "function", | ||
"nocompile": true, | ||
"description": "Gets the current UI language of the Operating System. This is different from $(ref:i18n.getUILanguage) which returns the UI language of the web browser.", | ||
"description": "Gets the current UI locale of the Operating System. This is different from $(ref:i18n.getUILanguage) which returns the UI locale of the web browser. This locale could include additional information like preferred datetime format and number system if supported by the OS.", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is the "additional information" part a standard? I know Apple platforms can include it, but that isn't something we have had in web extensions before. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @xeenon yes, this is specified by unicode. This was discussed during the shared session with the WECG/I18NWG meeting at TPAC. However, giving a further look at this I see how this should not be part of the getSystemUILanguage. Updated the PR to reflect this. Still, providing this information can be useful, but it should be implemented using some other method / proposal. |
||
"parameters": [], | ||
"returns": { | ||
"type": "string", | ||
"description": "A BCP47 language tag such as en-US or pt-BR." | ||
"returns_async": { | ||
"name": "callback", | ||
"parameters": [{ | ||
"type": "string", | ||
"description": "A BCP47 language tag such as en-US or pt-BR." | ||
}] | ||
} | ||
} | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.