[WIP] Missing ReadFileRecord in Modbus binding#445
Conversation
✅ Deploy Preview for wot-binding-templates ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
egekorkan
left a comment
egekorkan
left a comment
There was a problem hiding this comment.
Just a draft so leaving just a comment but the corresponding other document need to be updated too
|
I'm on it |
| ### https://www.w3.org/2019/wot/modbus#readFileRecord | ||
| :readFileRecord rdf:type owl:NamedIndividual , |
There was a problem hiding this comment.
| ### https://www.w3.org/2019/wot/modbus#readFileRecord | |
| :readFileRecord rdf:type owl:NamedIndividual , | |
| ### https://www.w3.org/2019/wot/modbus#ReadFileRecord | |
| :ReadFileRecord rdf:type owl:NamedIndividual , |
Other terms like Function use capital letters.
In general, there seems to be some inconsistency ... there is for example Data_Field that uses another casing with underscore ..
There was a problem hiding this comment.
This is inline with my comment here: #331 (comment)
Since, I will be working on the binding documents, will provide these fixes in future PRs
There was a problem hiding this comment.
@danielpeintner I checked this, there are some name inconsistencies, but currently we cannot modify this because it will invalidate the existing Modbus TD files in place.
…istent with the rest of the class names
… camel case naming convention
…uals naming based on the ontology file changes
…, needs to be clarified
…ction to Function to match with the ontology
…rred, but in the shacl shapes modbus prefix is used, added the import statement
|
The rendered document is available at https://deploy-preview-445--wot-binding-templates.netlify.app/bindings/protocols/modbus/ |
…stiankb-modbus-patch-1
4 participants
The list in https://w3c.github.io/wot-binding-templates/bindings/protocols/modbus/#function miss the functon code 0x14 for ReadFileRecord. This PR append this missing entry.