Skip to content

ignore false alarm API limit error in log #2927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JanuarySnow wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ignore false alarm API limit error in log #2927

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions Wabbajack.Reporting/LogDiagnosticService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
using System;
using System.Linq;
using System.Net.Http;
using Wabbajack.Reporting;

using System.Text.RegularExpressions;
namespace Wabbajack.Reporting;

public sealed record DiagnosticResult(string Title, string Body, string? ImagePathOrUrl)
Expand All @@ -24,6 +23,8 @@ public sealed class LogDiagnosticService : ILogDiagnosticService
private readonly IReadOnlyDictionary<string, TagConfig> _tags;
private readonly string _baseDir;
private static readonly HttpClient _http = new HttpClient();
private static readonly Regex _positiveRemainingLimit =
new(@"Remaining Limit:\s*[1-9]", RegexOptions.IgnoreCase | RegexOptions.Compiled);

public LogDiagnosticService(RemoteTagRepository repo, string? baseDir = null)
: this(repo.Tags, baseDir) { }
Expand Down Expand Up @@ -59,6 +60,16 @@ public DiagnosticResult Analyze(string logText)
if (names.Contains("notenoughspace") && names.Contains("path_not_found"))
return Build(matches.First(m => m.Tag.Name.Equals("notenoughspace", StringComparison.OrdinalIgnoreCase)).Tag);

// If the "api" tag fired on "Remaining Limit: 0" but a later log line shows >0 then itz not real
var apiEntry = matches.FirstOrDefault(m => m.Tag.Name.Equals("api", StringComparison.OrdinalIgnoreCase));
if (apiEntry.Tag is not null)
{
var tail = logText[(apiEntry.Index + 1)..];
if (_positiveRemainingLimit.IsMatch(tail))
matches.Remove(apiEntry);
}

if (matches.Count == 0) return DiagnosticResult.None;
return Build(matches.MaxBy(m => m.Index).Tag);
}

Expand Down
Loading